Skip to content

Use swagger api for Site Replication Status #3208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 25, 2024
Merged

Use swagger api for Site Replication Status #3208

merged 2 commits into from
Jan 25, 2024

Conversation

cesnietor
Copy link
Collaborator

Test Steps

  1. Go to /settings/site-replication
  2. Add a site to replicate data
  3. Click on Replication Status
  4. It should load the data from tha replication status

@cesnietor cesnietor self-assigned this Jan 20, 2024
bexsoft
bexsoft reviewed Jan 20, 2024
View reviewed changes
Copy link
Collaborator

@bexsoft bexsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review failing tests

prakashsvmx
prakashsvmx previously approved these changes Jan 24, 2024
View reviewed changes
Copy link
Member

@prakashsvmx prakashsvmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified. LGTM 👍

@cesnietor
Copy link
Collaborator Author

Please review failing tests

@bexsoft these seem unrelated to this change.

@cesnietor cesnietor force-pushed the use-swagger-site-replication-status branch from 3f7a952 to 385cb52 Compare January 24, 2024 17:44
bexsoft
bexsoft approved these changes Jan 25, 2024
View reviewed changes
Copy link
Collaborator

@bexsoft bexsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remaining failure not related to this change, there were a couple of failures in the first iteration of this PR. hence LGTM

@bexsoft bexsoft merged commit df2e92e into minio:master Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reivaj05 reivaj05 reivaj05 approved these changes

@prakashsvmx prakashsvmx prakashsvmx approved these changes

@bexsoft bexsoft bexsoft approved these changes

@pjuarezd pjuarezd Awaiting requested review from pjuarezd

@cniackz cniackz Awaiting requested review from cniackz

@dvaldivia dvaldivia Awaiting requested review from dvaldivia

@kaankabalak kaankabalak Awaiting requested review from kaankabalak

@adriangitvitz adriangitvitz Awaiting requested review from adriangitvitz

@jinapurapu jinapurapu Awaiting requested review from jinapurapu

Assignees

@cesnietor cesnietor

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cesnietor @reivaj05 @prakashsvmx @bexsoft