Skip to content

Remove useAPI from DeleteUser and DeleteIDPConfigurationModal #3191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 17, 2024
Merged

Remove useAPI from DeleteUser and DeleteIDPConfigurationModal #3191

merged 4 commits into from
Jan 17, 2024

Conversation

dvaldivia
Copy link
Collaborator

No description provided.

@dvaldivia dvaldivia self-assigned this Jan 16, 2024
@cesnietor
Copy link
Collaborator

@dvaldivia :

uilding Console binary to './console'
# github.com/minio/console/api/operations/user
api/operations/user/check_user_service_accounts_parameters.go:58:23: undefined: models.SelectedUsers
api/operations/user/check_user_service_accounts_parameters.go:72:19: undefined: models.SelectedUsers
make: *** [console] Error 1

missing file models/selected_users.go

@prakashsvmx
Copy link
Member

@dvaldivia , it could bot be re based. could you re base ?

cesnietor
cesnietor requested changes Jan 17, 2024
View reviewed changes
@dvaldivia
Remove useAPI from DeleteUser and DeleteIDPConfigurationModal
ff1883d 
Signed-off-by: Daniel Valdivia <[email protected]>
@dvaldivia
remove unnecesary line
671d35e 
Signed-off-by: Daniel Valdivia <[email protected]>
@dvaldivia
Add Missing Files
cd0c532 
Signed-off-by: Daniel Valdivia <[email protected]>
@dvaldivia
Address comments
e9400d0 
Signed-off-by: Daniel Valdivia <[email protected]>
@cesnietor cesnietor enabled auto-merge (squash) January 17, 2024 23:37
@cesnietor cesnietor self-requested a review January 17, 2024 23:37
@cesnietor cesnietor merged commit 2474232 into minio:master Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reivaj05 reivaj05 reivaj05 approved these changes

@cesnietor cesnietor cesnietor approved these changes

@prakashsvmx prakashsvmx Awaiting requested review from prakashsvmx

@bexsoft bexsoft Awaiting requested review from bexsoft

@adriangitvitz adriangitvitz Awaiting requested review from adriangitvitz

@jinapurapu jinapurapu Awaiting requested review from jinapurapu

Assignees

@dvaldivia dvaldivia

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dvaldivia @cesnietor @prakashsvmx @reivaj05