fix event dest icons not loading when subpath is configured #3169
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prakashsvmx
requested review from
reivaj05,
cesnietor,
dvaldivia,
bexsoft and
jinapurapu
dvaldivia
approved these changes
Dec 26, 2023
dvaldivia
reviewed
Dec 26, 2023
| @@ -48,65 +47,69 @@ export class DestType { | |||
| static Func: string = "functions"; | |||
| } | |||
|
|
|||
| const getImgBaseURL = () => { | |||
There was a problem hiding this comment.
I think we could use ${document.baseURI} directly instead of this function
cesnietor
pushed a commit
to cesnietor/console
that referenced
this pull request
Jan 12, 2024
Co-authored-by: Daniel Valdivia <[email protected]>
cesnietor
pushed a commit
to cesnietor/console
that referenced
this pull request
Jan 12, 2024
Co-authored-by: Daniel Valdivia <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix event dest icons not loading when subpath is configured
fixes #3151
how does it look: