Skip to content

Conversation

prakashsvmx
Copy link
Member

@prakashsvmx prakashsvmx commented Oct 31, 2023

access keys ui details improvement and edit
Adds Ability to add/edit expiry and other editable fields.

Fixes #3064
Fixes #3133

How does it look

image

image

image

image

User specific

image

image

@prakashsvmx prakashsvmx self-assigned this Oct 31, 2023
@prakashsvmx prakashsvmx force-pushed the svcacc-improvements branch 4 times, most recently from 9e5d639 to c25b666 Compare November 2, 2023 07:13
@prakashsvmx prakashsvmx marked this pull request as ready for review November 2, 2023 07:32
@prakashsvmx
Copy link
Member Author

@bexsoft make swagger-gen affected more files. is anything missed or changed recently ?

@prakashsvmx prakashsvmx force-pushed the svcacc-improvements branch 2 times, most recently from c25b666 to a730dd1 Compare November 6, 2023 09:36
@bexsoft
Copy link
Collaborator

bexsoft commented Nov 6, 2023

@bexsoft make swagger-gen affected more files. is anything missed or changed recently ?

Swagger version was updated a couple of PRs back, you'll need to upgrade to latest

Copy link
Collaborator

@bexsoft bexsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Just small style adjustments needed, will be changed later

Copy link
Collaborator

@cesnietor cesnietor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding tests.
Can we make it next time the BE and UI changes in separate PRs? so that they are easier to review? thank you!!

@jinapurapu
Copy link
Contributor

Can the comments be viewed/edited?

@prakashsvmx
Copy link
Member Author

@cesnietor make swagger-gen also updates typescript api file. So I will check for the best approach next time.

@prakashsvmx
Copy link
Member Author

@jinapurapu the upstream api does not have an option to update comments. We can check and update later when it supports.

@bexsoft bexsoft merged commit e4d5f96 into minio:master Nov 22, 2023
@prakashsvmx prakashsvmx deleted the svcacc-improvements branch November 22, 2023 04:09
cesnietor pushed a commit to cesnietor/console that referenced this pull request Jan 12, 2024
cesnietor pushed a commit to cesnietor/console that referenced this pull request Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

There is no way to add or edit expire time/name /description when i craete Access Keys Allow to add Description of Access key via MinIO console
4 participants