-
Notifications
You must be signed in to change notification settings - Fork 446
access keys ui details improvement and edit #3116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
9e5d639
to
c25b666
Compare
@bexsoft |
c25b666
to
a730dd1
Compare
Swagger version was updated a couple of PRs back, you'll need to upgrade to latest |
cfc0922
to
bcaf02f
Compare
36e93db
to
6cccd8a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Just small style adjustments needed, will be changed later
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding tests.
Can we make it next time the BE and UI changes in separate PRs? so that they are easier to review? thank you!!
Can the comments be viewed/edited? |
@cesnietor |
@jinapurapu the upstream api does not have an option to update comments. We can check and update later when it supports. |
access keys ui details improvement and edit
Adds Ability to add/edit expiry and other editable fields.
Fixes #3064
Fixes #3133
User specific