Skip to content

Conversation

jinapurapu
Copy link
Contributor

Adds placeholder image with text describing the Help Menu status when outside image links are not available.

Screen.Recording.2023-06-21.at.2.47.12.PM.mov

@jinapurapu jinapurapu added the WIP This PR is WIP and cannot be merged yet label Jun 21, 2023
@jinapurapu jinapurapu self-assigned this Jun 21, 2023
@cesnietor
Copy link
Collaborator

cesnietor commented Jun 21, 2023

If there is no internet, they won't be able to go to the links (from Learn More), which would make the user experience confusing, so what about disabling the whole help menu? Or do we have info that can be shown without internet?

@jinapurapu
Copy link
Contributor Author

If there is no internet, they won't be able to go to the links (from Learn More), which would make the user experience confusing, so what about disabling the whole help menu? Or do we have info that can be shown without internet?

Yes, that is why the text explains this for now. I am still working on disabling the Help Menu or replacing with a limited offline mode if the links can't be reached.

@cesnietor cesnietor merged commit c3da876 into minio:master Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WIP This PR is WIP and cannot be merged yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants