Pass Client IP address to MinIO on x-forwarded-for header #2864
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvaldivia
requested review from
vadmeste,
harshavardhana,
pjuarezd,
reivaj05,
cesnietor,
allanrogerr,
prakashsvmx,
bexsoft,
jinapurapu and
dilverse
cesnietor
reviewed
Jun 12, 2023
dvaldivia
force-pushed
the
pass-client-ip
branch
2 times, most recently
from
14f41b6 to
9f17bab
Compare
reivaj05
requested changes
Jun 13, 2023
Signed-off-by: Daniel Valdivia <[email protected]>
dvaldivia
force-pushed
the
pass-client-ip
branch
from
5e8fd89 to
3667fb7
Compare
bexsoft
approved these changes
Jun 14, 2023
vadmeste
reviewed
Jun 14, 2023
reivaj05
approved these changes
Jun 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a custom
RoundTripperfor the transport we use when communicating with MinIO via the SDKs.The intention is to communicate the IP address of the actual user to MinIO.
While reviewing this PR:
If the request was available, that was used as an inline solution, like when the client is instantiated from the handler
context.Contextwas used whenever was possible as the middleware can introduce the IP address and have it be pass it aroundwebsocket can't use the same
context.Contexthave their own remoteAddress callFixes #2290