Skip to content

Conversation

reivaj05
Copy link
Contributor

@reivaj05 reivaj05 commented Jun 9, 2023

No description provided.

@cesnietor
Copy link
Collaborator

It LGTM although I would like to see if we can get those checks to pass. Did all skipped ones fail?

dvaldivia
dvaldivia previously approved these changes Jun 13, 2023
Copy link
Collaborator

@bexsoft bexsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an issue trying to reate a general access key, it throws the following error:
Screenshot 2023-06-12 at 19 14 29

After trying to add an empty replication rule, page crashes

Screenshot 2023-06-12 at 19 18 25

Copy link
Collaborator

@cesnietor cesnietor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested happy paths and common flows and LGTM

@dvaldivia dvaldivia merged commit aa9b735 into minio:master Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants