Skip to content

Conversation

bexsoft
Copy link
Collaborator

@bexsoft bexsoft commented Apr 11, 2023

fixes #2767

What does this do?

  • Fixed Object Version selector visibility in Add Lifecycle Rule modal
  • Changed definition in swagger file to match camelCase standard
  • Added a playwright test case to avoid this issue in the future

How does it look?

Screenshot 2023-04-10 at 18 23 06

dilverse
dilverse previously approved these changes Apr 11, 2023
prakashsvmx
prakashsvmx previously approved these changes Apr 11, 2023
Copy link
Member

@prakashsvmx prakashsvmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified. Changes look good to me.

Feedback:
When a Rule is viewed, the "Object version" dropdown should indicate if it is Current version or non current version

Sample ILM
{
 "Rules": [
  {
   "Expiration": {
    "ExpiredObjectDeleteMarker": true
   },
   "ID": "cgqd3g6h3vkkls89bou0",
   "Status": "Enabled"
  },
  {
   "Expiration": {
    "Days": 1
   },
   "ID": "cgqd46eh3vkki7rr1cv0",
   "Status": "Enabled"
  },
  {
   "ID": "cgqd4k6h3vkkheif2te0",
   "NoncurrentVersionExpiration": {
    "NoncurrentDays": 0,
    "NewerNoncurrentVersions": 1
   },
   "Status": "Enabled"
  }
 ]
}

@bexsoft
Copy link
Collaborator Author

bexsoft commented Apr 11, 2023

Verified. Changes look good to me.

Feedback: When a Rule is viewed, the "Object version" dropdown should indicate if it is Current version or non current version

Sample ILM

This is not implemented right now in edit ILM rule. Will add this in an upcoming PR

@dvaldivia dvaldivia merged commit 75b3a6b into minio:master Apr 11, 2023
@dvaldivia dvaldivia deleted the ilm-issue branch April 11, 2023 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ILM rule add non-current version broken
4 participants