Delete secrets created if it fails on tenant creation #274
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also a fix on a parity condition has been fixed.
Alevsk
reviewed
Sep 9, 2020
Comment on lines
-201
to
-217
| errDelete := clientSet.deleteSecret(ctx, ns, tenantExternalClientCertSecretName, metav1.DeleteOptions{}) | ||
| if errDelete != nil { | ||
| log.Print(errDelete) | ||
| } | ||
| errDelete = clientSet.deleteSecret(ctx, ns, kesExternalCertSecretName, metav1.DeleteOptions{}) | ||
| if errDelete != nil { | ||
| log.Print(errDelete) | ||
| } | ||
| errDelete = clientSet.deleteSecret(ctx, ns, kesClientCertSecretName, metav1.DeleteOptions{}) | ||
| if errDelete != nil { | ||
| log.Print(errDelete) | ||
| } | ||
| errDelete = clientSet.deleteSecret(ctx, ns, kesConfigurationSecretName, metav1.DeleteOptions{}) | ||
| if errDelete != nil { | ||
| log.Print(errDelete) | ||
| } | ||
| return |
There was a problem hiding this comment.
where did this code got moved?
There was a problem hiding this comment.
Cause that will be handled by the defer function on create Tenant func, I also saw that this function was only being used there. Do you think this will be used in other funcs?
Alevsk
approved these changes
Sep 10, 2020
dvaldivia
reviewed
Sep 10, 2020
| @@ -713,7 +726,7 @@ func getTenantCreatedResponse(session *models.Principal, params admin_api.Create | |||
|
|
|||
| if tenantReq.ImagePullSecret != "" { | |||
| imagePullSecret = tenantReq.ImagePullSecret | |||
| } else if imagePullSecret, err = setImageRegistry(ctx, tenantName, tenantReq.ImageRegistry, clientSet.CoreV1(), ns); err != nil { | |||
| } else if imagePullSecret, err = setImageRegistry(ctx, tenantReq.ImageRegistry, clientSet.CoreV1(), ns, tenantName); err != nil { | |||
There was a problem hiding this comment.
how was this working before? o_O
dvaldivia
approved these changes
Sep 10, 2020
| @@ -713,7 +726,7 @@ func getTenantCreatedResponse(session *models.Principal, params admin_api.Create | |||
|
|
|||
| if tenantReq.ImagePullSecret != "" { | |||
| imagePullSecret = tenantReq.ImagePullSecret | |||
| } else if imagePullSecret, err = setImageRegistry(ctx, tenantName, tenantReq.ImageRegistry, clientSet.CoreV1(), ns); err != nil { | |||
| } else if imagePullSecret, err = setImageRegistry(ctx, tenantReq.ImageRegistry, clientSet.CoreV1(), ns, tenantName); err != nil { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an error happened on tenant creation, if any secret was created before, the secret was not being removed. This helps by making sure all the secrets are being deleted if any on an error.
Also a fix on a parity condition has been fixed.