Fixed Drives offline card UI #2732
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… these first choice for drive status UI
jinapurapu
requested review from
harshavardhana,
pjuarezd,
cniackz,
reivaj05,
allanrogerr,
dvaldivia,
prakashsvmx,
kaankabalak,
bexsoft and
dilverse
added 2 commits
March 22, 2023 17:05
|
Thank you very much @jinapurapu for this fix, this looks so much better this time. And also thank you for the short video or GIF on the description. This looks good to me. |
dilverse
approved these changes
Mar 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Offline drives were being reported incorrectly, this adds the more accurate backend.onlineDisks and backend.offlineDisks to the admin info api, and uses them as the first choice for the drive status UI card.
Screen.Recording.2023-03-22.at.4.45.11.PM.mov
#2731
Testing: