Fixed snackMessage to display if error returned creating policy #2726
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jinapurapu
requested review from
pjuarezd,
cniackz,
reivaj05,
allanrogerr,
dvaldivia,
prakashsvmx,
kaankabalak,
bexsoft and
dilverse
kaankabalak
reviewed
Mar 20, 2023
Co-authored-by: Kaan Kabalak <[email protected]>
kaankabalak
reviewed
Mar 20, 2023
added 3 commits
March 20, 2023 16:03
kaankabalak
approved these changes
Mar 20, 2023
|
there's some lint problems @jinapurapu |
bexsoft
requested changes
Mar 21, 2023
reivaj05
approved these changes
Mar 22, 2023
bexsoft
approved these changes
Mar 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Errors returned when creating a policy were not being displayed, now display along with guiding text for user.
fixes https://github.com/miniohq/engineering/issues/1183