Condensing Successful responses #2722
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cniackz
force-pushed
the
condensing_success_codes
branch
from
76e4b75 to
cfdfe77
Compare
cniackz
requested review from
reivaj05,
jinapurapu,
prakashsvmx,
dvaldivia,
pjuarezd and
harshavardhana
allanrogerr
approved these changes
Mar 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective:
Condensing Successful responses (200 – 299) and as long as Bucket is created with no errors, we should proceed testing. We can be very very strict in the codes but I believe is better to be flexible for the successful ones because it is time consuming debugging and fixing for minor changes that are giving little in return. For other responses like 400s or 500s being strict is much more reasonable.
Note:
This is for testing only, but related to #2721
How to test locally:
https://github.com/cniackz/public/wiki/Integration-tests-in-console