LDAP Page improvements #2708
Merged
LDAP Page improvements #2708
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removed multiple LDAP support - Fixed add LDAP configuration - Fixed Edit LDAP configuration - Fixed retrieve LDAP configuration parameters - Fixed reset LDAP configuration support - Added Entities search support Signed-off-by: Benjamin Perez <[email protected]>
bexsoft
requested review from
pjuarezd,
cniackz,
reivaj05,
allanrogerr,
dvaldivia,
prakashsvmx,
kaankabalak,
jinapurapu and
dilverse
|
Does this already work without minio/minio#16805 ? |
Enable / Disable functionality is not enabled yet in this PR. |
dvaldivia
approved these changes
Mar 16, 2023
allanrogerr
approved these changes
Mar 16, 2023
|
@bexsoft Just not sure why we need the little clock? |
|
Enable / Disable LDAP will be activated in a following PR |
Server returns a timestamp of the query, We may need another clock icon for this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
How does it look?