Removing old cache spot for permission test and incrementing the timeout. #2395
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cniackz
requested review from
dvaldivia,
adfost,
Alevsk,
bexsoft,
harshavardhana,
jinapurapu,
kaankabalak,
pjuarezd,
prakashsvmx and
reivaj05
reivaj05
previously approved these changes
Oct 18, 2022
cniackz
changed the title
cniackz
force-pushed
the
fix-permission-test-4-part2
branch
from
efc6805 to
b99579a
Compare
cniackz
changed the title
cniackz
changed the title
jinapurapu
approved these changes
Oct 18, 2022
bexsoft
approved these changes
Oct 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective:
To fix
Permissions Tests Part 4by removing old cache spot that is no longer needed and incrementing the timeout.Additional information:
Also incrementing the timeout from 5 minutes to 15 minutes for the overall test. And from 5 minutes to 10 minutes for the testcafe test as 5 minutes is not enough.
Result: