Skip to content

ignore configs with no KVs and simplify config builder #2342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 30, 2022
Merged

ignore configs with no KVs and simplify config builder #2342

merged 2 commits into from
Sep 30, 2022

Conversation

harshavardhana
Copy link
Member

convert all \n to ','

@harshavardhana harshavardhana mentioned this pull request Sep 28, 2022
Closed
bexsoft
bexsoft approved these changes Sep 30, 2022
View reviewed changes
Copy link
Collaborator

@bexsoft bexsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@harshavardhana harshavardhana merged commit 5cf2b73 into minio:master Sep 30, 2022
@harshavardhana harshavardhana deleted the skip-config-kvs branch September 30, 2022 07:16
@harshavardhana harshavardhana mentioned this pull request Sep 30, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prakashsvmx prakashsvmx prakashsvmx approved these changes

@bexsoft bexsoft bexsoft approved these changes

Assignees

@harshavardhana harshavardhana

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@harshavardhana @prakashsvmx @bexsoft