-
Notifications
You must be signed in to change notification settings - Fork 447
Interactive Bucket Naming Rules component #2262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
portal-ui/src/screens/Console/Buckets/ListBuckets/AddBucket/BucketNamingRules.tsx
Outdated
Show resolved
Hide resolved
portal-ui/src/screens/Console/Buckets/ListBuckets/AddBucket/BucketNamingRules.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we keep the colors the same as they're used on other components?
I think blue should be #0288D1 while red should be #C83B51.
Is it possible to have greyed out bullets and they show the checkmark just once that specific rule has passed?
Thanks!
@jinapurapu
|
portal-ui/src/screens/Console/Buckets/ListBuckets/AddBucket/AddBucket.tsx
Outdated
Show resolved
Hide resolved
151103d
to
018d95b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested. Looks good to me. 👍
Yeah, this would be great to implement! Thanks for the suggestion @prakashsvmx |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, works ok
closes https://github.com/miniohq/engineering/issues/961