Skip to content

Conversation

jinapurapu
Copy link
Contributor

@jinapurapu jinapurapu commented Aug 23, 2022

reivaj05
reivaj05 previously approved these changes Aug 23, 2022
Copy link

@oscarocastellanos oscarocastellanos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we keep the colors the same as they're used on other components?
I think blue should be #0288D1 while red should be #C83B51.

Is it possible to have greyed out bullets and they show the checkmark just once that specific rule has passed?

Thanks!

@prakashsvmx
Copy link
Member

prakashsvmx commented Aug 24, 2022

@jinapurapu
Observations:

  • Also if we could refactor and highlight the bucket name field when at least one rule is not met, it would be a great user experience.( or we could expand the rules by default ). for example if a rule fails, the user has to expand and see
    @oscarocastellanos any thoughts?

  • All of unmet rules need to be highlighted for errors. e.g A-..

@jinapurapu jinapurapu force-pushed the bucket_naming_rules branch from 151103d to 018d95b Compare August 25, 2022 19:37
Copy link
Member

@prakashsvmx prakashsvmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested. Looks good to me. 👍

@oscarocastellanos
Copy link

@jinapurapu Observations:

  • Also if we could refactor and highlight the bucket name field when at least one rule is not met, it would be a great user experience.( or we could expand the rules by default ). for example if a rule fails, the user has to expand and see
    @oscarocastellanos any thoughts?
  • All of unmet rules need to be highlighted for errors. e.g A-..

Yeah, this would be great to implement! Thanks for the suggestion @prakashsvmx

Copy link
Collaborator

@bexsoft bexsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, works ok

@bexsoft bexsoft merged commit 3a3a4b2 into minio:master Aug 30, 2022
@djwfyi djwfyi mentioned this pull request Sep 7, 2022
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants