Skip to content

Created button to download Widget data as CSV or PNG file #2241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Aug 19, 2022
Merged

Created button to download Widget data as CSV or PNG file #2241

merged 8 commits into from
Aug 19, 2022

Conversation

jinapurapu
Copy link
Contributor

@jinapurapu jinapurapu commented Aug 10, 2022 •
edited
Loading

@jinapurapu jinapurapu self-assigned this Aug 10, 2022
oscarocastellanos
oscarocastellanos reviewed Aug 10, 2022
View reviewed changes
Copy link

@oscarocastellanos oscarocastellanos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we improve the alignment of the button? I'm leaving here an example of the desired alignment. It should rest in the same horizontal line as the box title and should have a margin to the right the same as the margin to the right of the box title.
Captura de Pantalla 2022-08-10 a la(s) 16 39 52

@jinapurapu jinapurapu force-pushed the widgets_png_download branch from d97b953 to 7b3a532 Compare August 11, 2022 01:59
kaankabalak
kaankabalak reviewed Aug 16, 2022
View reviewed changes
@jinapurapu jinapurapu force-pushed the widgets_png_download branch from 7b3a532 to da5d4d1 Compare August 16, 2022 16:50
@jinapurapu jinapurapu force-pushed the widgets_png_download branch from da5d4d1 to b4be5ec Compare August 18, 2022 17:06
@jinapurapu jinapurapu requested review from oscarocastellanos and removed request for kaankabalak August 19, 2022 15:40
oscarocastellanos
oscarocastellanos approved these changes Aug 19, 2022
View reviewed changes
Copy link

@oscarocastellanos oscarocastellanos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

bexsoft
bexsoft approved these changes Aug 19, 2022
View reviewed changes
Copy link
Collaborator

@bexsoft bexsoft left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, In the line charts CSV the first column can be changed to be a date. this can be done in another PR

@bexsoft bexsoft merged commit 292fb39 into minio:master Aug 19, 2022
@djwfyi djwfyi mentioned this pull request Aug 24, 2022
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reivaj05 reivaj05 reivaj05 approved these changes

@kaankabalak kaankabalak kaankabalak approved these changes

@bexsoft bexsoft bexsoft approved these changes

@oscarocastellanos oscarocastellanos oscarocastellanos approved these changes

@Alevsk Alevsk Awaiting requested review from Alevsk

@cniackz cniackz Awaiting requested review from cniackz

@adfost adfost Awaiting requested review from adfost

@dvaldivia dvaldivia Awaiting requested review from dvaldivia

@prakashsvmx prakashsvmx Awaiting requested review from prakashsvmx

Assignees

@jinapurapu jinapurapu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jinapurapu @reivaj05 @kaankabalak @bexsoft @oscarocastellanos