Skip to content

remove remaining variable references for mcs #214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 28, 2020
Merged

remove remaining variable references for mcs #214

merged 1 commit into from
Jul 28, 2020

Conversation

harshavardhana
Copy link
Member

No description provided.

@cesnietor
Copy link
Collaborator

cesnietor commented Jul 28, 2020 •
edited
Loading

Lol this I also thought was necessary but the MCS3Client there reflects the mc S3 client definition, is just to call mc functions.
So not needed XD.

@harshavardhana
Copy link
Member Author

Lol this I also thought was necessary but the MCS3Client there reflects the mc S3 client definition, is just to call mc functions.
So not needed XD.

is it necessary to call it mc S3 client?

@cesnietor
Copy link
Collaborator

cesnietor commented Jul 28, 2020 •
edited
Loading

is it necessary to call it mc S3 client?

mmh well it is that, any suggestions? probably minioClient?

@harshavardhana
Copy link
Member Author

To avoid the confusion moved to mcClient instead of mcS3Client

@dvaldivia dvaldivia merged commit af8eb9a into master Jul 28, 2020
@dvaldivia dvaldivia deleted the remove-mcs branch July 28, 2020 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cesnietor cesnietor cesnietor approved these changes

@dvaldivia dvaldivia dvaldivia approved these changes

+1 more reviewer

@Alevsk Alevsk Alevsk approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@harshavardhana harshavardhana

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@harshavardhana @cesnietor @Alevsk @dvaldivia @minio-trusted