Add storageClass as part of tenant info api response #196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cesnietor
force-pushed
the
add-storageclass-tenant
branch
from
07684c3 to
5c2f413
Compare
Alevsk
previously approved these changes
Jul 16, 2020
restapi/admin_tenants_test.go
Outdated
| got, err := getTenantAdminClient(tt.args.ctx, tt.args.client, tt.args.namespace, tt.args.tenantName, tt.args.serviceName, tt.args.scheme) | ||
| _, err := getTenantAdminClient(tt.args.ctx, tt.args.client, tt.args.namespace, tt.args.tenantName, tt.args.serviceName, tt.args.scheme) |
There was a problem hiding this comment.
why we stop comparing the actual result?
There was a problem hiding this comment.
this is just to ensure that an adminClient is created, we don't need to check the elements of it since that is not the purpose of that function but, I can add an assertion that the type is the one we expect.
There was a problem hiding this comment.
also because all contents on AdminClient are Private XD but I've added the validation
cesnietor
force-pushed
the
add-storageclass-tenant
branch
from
5c2f413 to
eaac292
Compare
bexsoft
requested changes
Jul 16, 2020
There was a problem hiding this comment.
storage_class is not being returned by API, Is there anything special that needs to be done?
{
"creation_date": "2020-07-10 19:56:19 +0000 UTC",
"currentState": "Ready",
"image": "minio/minio:RELEASE.2020-06-03T22-13-49Z",
"instance_count": 11,
"name": "minio-tenant-1",
"namespace": "default",
"total_size": 94489280512,
"used_size": 227723329536,
"volume_count": 44,
"volume_size": 2147483648,
"volumes_per_server": 4,
"zone_count": 5,
"zones": [
{
"name": "zone-0",
"servers": 1
},
{
"name": "zone-asdfasdfasdfasdfs",
"servers": 2
},
{
"name": "zone-3-8cca5.e6f026a7",
"servers": 1
},
{
"name": "zone-4-2ba58",
"servers": 5
},
{
"name": "zone-5-1b03ea",
"servers": 2
}
]
}
API call: http://localhost:9090/api/v1/namespaces/default/tenants/minio-tenant-1
bexsoft
approved these changes
Jul 16, 2020
Alevsk
approved these changes
Jul 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.