Skip to content

Conversation

bexsoft
Copy link
Collaborator

@bexsoft bexsoft commented May 26, 2020

fixes #143

What does this do?

Added flag to only enable operator endpoints / links in mcs

How to test

  • Enable MCS_OPERATOR_ONLY flag as "on" before running server
  • Run server as usual

Screen Shot 2020-05-26 at 3 26 04 PM
Screen Shot 2020-05-26 at 3 25 06 PM

@bexsoft bexsoft requested review from Alevsk, cesnietor and dvaldivia May 26, 2020 20:45
@bexsoft bexsoft self-assigned this May 26, 2020
Copy link
Collaborator

@cesnietor cesnietor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should remove the Remove this: Test XD

@cesnietor
Copy link
Collaborator

also the assets were not built

@bexsoft bexsoft added the WIP This PR is WIP and cannot be merged yet label May 26, 2020
@bexsoft
Copy link
Collaborator Author

bexsoft commented May 26, 2020

Remove this: Tes

I couldn't find this test :/

@cesnietor
Copy link
Collaborator

Remove this: Tes

I couldn't find this test :/

it is in ListClusters.tsx.

<Grid item xs={12}>
          REMOVE THIS:: <Link to={"/clusters/demoCluster"}>Test</Link>
          <br />
        </Grid>

@bexsoft
Copy link
Collaborator Author

bexsoft commented May 26, 2020

Remove this: Tes

I couldn't find this test :/

it is in ListClusters.tsx.

<Grid item xs={12}>
          REMOVE THIS:: <Link to={"/clusters/demoCluster"}>Test</Link>
          <br />
        </Grid>

Removed :)

@bexsoft bexsoft requested a review from cesnietor May 26, 2020 22:46
cesnietor
cesnietor previously approved these changes May 26, 2020
@bexsoft bexsoft removed the WIP This PR is WIP and cannot be merged yet label May 26, 2020
dvaldivia
dvaldivia previously approved these changes May 27, 2020
cesnietor
cesnietor previously approved these changes May 27, 2020
Copy link
Collaborator

@cesnietor cesnietor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cesnietor
cesnietor previously approved these changes May 27, 2020
Added flag to only enable operator endpoints / links in mcs
@cesnietor cesnietor self-requested a review May 27, 2020 02:26
Copy link
Collaborator

@cesnietor cesnietor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested LGTM

@cesnietor cesnietor merged commit be5cd7f into minio:master May 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create operator only flag for mcs
3 participants