Add admin heal api and ui #142
Conversation
cesnietor
force-pushed
the
mcs-heal
branch
2 times, most recently
from
7f2adab to
cb57152
Compare
| // interface HealStatus { | ||
| // beforeHeal: number[]; | ||
| // afterHeal: number[]; | ||
| // objectsHealed: number; | ||
| // objectsScanned: number; | ||
| // healDuration: number; | ||
| // sizeScanned: string; | ||
| // } |
There was a problem hiding this comment.
if this code is not need it please delete it
| interface colorH { | ||
| [Green: string]: number; | ||
| Yellow: number; | ||
| Red: number; | ||
| Grey: number; | ||
| } |
There was a problem hiding this comment.
should this be moved to the heal/types.ts file?
restapi/admin_heal.go
Outdated
| if req.FormValue("force-start") != "" { | ||
| boolVal, err := strconv.ParseBool(req.FormValue("force-start")) | ||
| if err != nil { | ||
| return healOptions{}, err |
There was a problem hiding this comment.
should we return nil instead of an empty struct? in the case of yes func return should be changed to *healOptions too
restapi/admin_heal.go
Outdated
|
|
||
| // getHealOptionsFromReq return options from request for healing process | ||
| // path come as : `/heal/bucket1` and query params come on request form | ||
| func getHealOptionsFromReq(req *http.Request) (hOptions healOptions, err error) { |
There was a problem hiding this comment.
I think we should return pointer to struct to be consistent with the functions called by the other endpoints
| func getHealOptionsFromReq(req *http.Request) (hOptions healOptions, err error) { | |
| func getHealOptionsFromReq(req *http.Request) (hOptions *healOptions, err error) { |
| createStyles({ | ||
| watchList: { | ||
| background: "white", | ||
| maxHeight: "400px", |
There was a problem hiding this comment.
Please use only numeric values in createStyles function when using pixels
| maxHeight: "400px", | |
| maxHeight: 400, |
| maxHeight: "400px", | ||
| overflow: "auto", | ||
| "& ul": { | ||
| margin: "4px", |
There was a problem hiding this comment.
| margin: "4px", | |
| margin: 4, |
| overflow: "auto", | ||
| "& ul": { | ||
| margin: "4px", | ||
| padding: "0px", |
There was a problem hiding this comment.
| padding: "0px", | |
| padding: 0 |
| borderRadius: 5, | ||
| marginLeft: 10, | ||
| textAlign: "left", | ||
| minWidth: "206px", |
There was a problem hiding this comment.
| minWidth: "206px", | |
| minWidth: 206, |
|
|
||
| interface colorH { | ||
| [Green: string]: number; | ||
| Yellow: number; |
There was a problem hiding this comment.
Shouldn't we have the same structure as Green for all the elements in the interface
There was a problem hiding this comment.
no, it seems that it should be only on the first one which will define the signature index :
else it shows Duplicate string index signature.
Test Steps:
Healminio server ./dat{1...4}rm -rf ./dat4