Changed modal forms to contain scrollbars #113
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed modal forms to contain scrollbars where the inputs are, so this way the titles and buttons get always visible.
dvaldivia
approved these changes
May 12, 2020
|
tested, LGTM. |
cesnietor
approved these changes
May 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #110
What does this do?
Changed modal forms to contain scrollbars where the inputs are, so this way the titles and buttons get always visible.
How to test
Go into long forms and check that all of them contain a scrollbar in the inputs section. Title & buttons must be always visible
You can shrink the window to check that the behavior also happens with small screens