Skip to content

[Modularize] Enhancement - New-EntraServicePrincipalPasswordCredential to include displayName property #1289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jan 21, 2025
Merged

[Modularize] Enhancement - New-EntraServicePrincipalPasswordCredential to include displayName property #1289

merged 6 commits into from
Jan 21, 2025

Conversation

@SteveMutungi254
Copy link
Contributor

@SteveMutungi254 SteveMutungi254 commented Jan 15, 2025

Modularize enhancement for New-EntraServicePrincipalPasswordCredential to include displayName property

@SteveMutungi254 SteveMutungi254 requested a review from a team as a code owner January 15, 2025 12:47
@learn-build-service-prod
Copy link

learn-build-service-prod bot commented Jan 15, 2025

Learn Build status updates of commit e8943ac:

✅ Validation status: passed

File Status Preview URL Details
module/Entra/Microsoft.Entra/Applications/New-EntraServicePrincipalPasswordCredential.ps1 ✅Succeeded
module/EntraBeta/Microsoft.Entra.Beta/Applications/New-EntraBetaServicePrincipalPasswordCredential.ps1 ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@learn-build-service-prod
Copy link

learn-build-service-prod bot commented Jan 15, 2025

Learn Build status updates of commit cbc5372:

✅ Validation status: passed

File Status Preview URL Details
module/docs/entra-powershell-beta/Applications/New-EntraBetaServicePrincipalPasswordCredential.md ✅Succeeded View (entra-powershell-beta-preview)
module/docs/entra-powershell-v1.0/Applications/New-EntraServicePrincipalPasswordCredential.md ✅Succeeded View (entra-powershell-preview)
module/Entra/Microsoft.Entra/Applications/New-EntraServicePrincipalPasswordCredential.ps1 ✅Succeeded
module/EntraBeta/Microsoft.Entra.Beta/Applications/New-EntraBetaServicePrincipalPasswordCredential.ps1 ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@learn-build-service-prod
Copy link

learn-build-service-prod bot commented Jan 15, 2025

Learn Build status updates of commit d8a3ce0:

✅ Validation status: passed

File Status Preview URL Details
module/docs/entra-powershell-beta/Applications/New-EntraBetaServicePrincipalPasswordCredential.md ✅Succeeded View (entra-powershell-beta-preview)
module/docs/entra-powershell-v1.0/Applications/New-EntraServicePrincipalPasswordCredential.md ✅Succeeded View (entra-powershell-preview)
module/Entra/Microsoft.Entra/Applications/New-EntraServicePrincipalPasswordCredential.ps1 ✅Succeeded
module/EntraBeta/Microsoft.Entra.Beta/Applications/New-EntraBetaServicePrincipalPasswordCredential.ps1 ✅Succeeded
test/Entra/Applications/New-EntraServicePrincipalPasswordCredential.Tests.ps1 ✅Succeeded
test/EntraBeta/Applications/New-EntraBetaServicePrincipalPasswordCredential.Tests.ps1 ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@learn-build-service-prod
Copy link

learn-build-service-prod bot commented Jan 16, 2025

Learn Build status updates of commit 9ab1459:

✅ Validation status: passed

File Status Preview URL Details
module/docs/entra-powershell-beta/Applications/New-EntraBetaServicePrincipalPasswordCredential.md ✅Succeeded View (entra-powershell-beta-preview)
module/docs/entra-powershell-v1.0/Applications/New-EntraServicePrincipalPasswordCredential.md ✅Succeeded View (entra-powershell-preview)
module/Entra/Microsoft.Entra/Applications/New-EntraServicePrincipalPasswordCredential.ps1 ✅Succeeded
module/EntraBeta/Microsoft.Entra.Beta/Applications/New-EntraBetaServicePrincipalPasswordCredential.ps1 ✅Succeeded
test/Entra/Applications/New-EntraServicePrincipalPasswordCredential.Tests.ps1 ✅Succeeded
test/EntraBeta/Applications/New-EntraBetaServicePrincipalPasswordCredential.Tests.ps1 ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@SteveMutungi254
Copy link
Contributor Author

SteveMutungi254 commented Jan 16, 2025

Related PR - #1187

@SteveMutungi254 SteveMutungi254 added P0 Highest priority Ready For Review The PR Ready for Review P1 and removed P0 Highest priority labels Jan 16, 2025
@SteveMutungi254
Copy link
Contributor Author

SteveMutungi254 commented Jan 16, 2025

Build completed successfully.

KenitoInc
KenitoInc reviewed Jan 21, 2025
View reviewed changes
test/Entra/Applications/New-EntraServicePrincipalPasswordCredential.Tests.ps1 Outdated
$originalDebugPreference = $DebugPreference
$DebugPreference = 'Continue'

Copy link
Collaborator

@KenitoInc KenitoInc Jan 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove whitespace

test/Entra/Applications/New-EntraServicePrincipalPasswordCredential.Tests.ps1 Outdated
}
}


Copy link
Collaborator

@KenitoInc KenitoInc Jan 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove extra line

test/EntraBeta/Applications/New-EntraBetaServicePrincipalPasswordCredential.Tests.ps1 Outdated
}
}


Copy link
Collaborator

@KenitoInc KenitoInc Jan 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove extra lines

@learn-build-service-prod
Copy link

learn-build-service-prod bot commented Jan 21, 2025

Learn Build status updates of commit 89cd018:

✅ Validation status: passed

File Status Preview URL Details
module/docs/entra-powershell-beta/Applications/New-EntraBetaServicePrincipalPasswordCredential.md ✅Succeeded View (entra-powershell-beta-preview)
module/docs/entra-powershell-v1.0/Applications/New-EntraServicePrincipalPasswordCredential.md ✅Succeeded View (entra-powershell-preview)
module/Entra/Microsoft.Entra/Applications/New-EntraServicePrincipalPasswordCredential.ps1 ✅Succeeded
module/EntraBeta/Microsoft.Entra.Beta/Applications/New-EntraBetaServicePrincipalPasswordCredential.ps1 ✅Succeeded
test/Entra/Applications/New-EntraServicePrincipalPasswordCredential.Tests.ps1 ✅Succeeded
test/EntraBeta/Applications/New-EntraBetaServicePrincipalPasswordCredential.Tests.ps1 ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@KenitoInc KenitoInc merged commit 814722f into modularize Jan 21, 2025
2 checks passed
KenitoInc pushed a commit that referenced this pull request Jan 31, 2025
@SteveMutungi254 @KenitoInc
[Modularize] Enhancement - New-EntraServicePrincipalPasswordCredentia…
e4a4ac5 
…l to include displayName property (#1289)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@KenitoInc KenitoInc KenitoInc approved these changes

Assignees

No one assigned

Labels

P1 Ready For Review The PR Ready for Review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@SteveMutungi254 @KenitoInc @stevemutungi