Skip to content

Remove unnecessary CA2022 suppressions #15035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 31, 2025
Merged

Remove unnecessary CA2022 suppressions #15035

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
64050f5
Remove unnecessary CA2022 suppressions
Winniexu01 Mar 26, 2025
8b0553b
Remove unnecessary CA2022 suppressions
Winniexu01 Mar 28, 2025
8115f36
Fix char type
Winniexu01 Mar 28, 2025
ce5b8e1
Format code
Winniexu01 Mar 31, 2025
a6e372c
Format extension method
Winniexu01 Mar 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 24 additions & 4 deletions src/Microsoft.TestPlatform.CoreUtilities/Helpers/DotnetHostHelper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -409,10 +409,9 @@ public bool TryGetDotnetPathByArchitecture(
using var headerReader = _fileHelper.GetStream(path, FileMode.Open, FileAccess.Read);
var magicBytes = new byte[4];
var cpuInfoBytes = new byte[4];
#pragma warning disable CA2022 // Avoid inexact read with 'Stream.Read'
headerReader.Read(magicBytes, 0, magicBytes.Length);
headerReader.Read(cpuInfoBytes, 0, cpuInfoBytes.Length);
#pragma warning restore CA2022 // Avoid inexact read with 'Stream.Read'

ReadExactly(headerReader, magicBytes, 0, magicBytes.Length);
ReadExactly(headerReader, cpuInfoBytes, 0, cpuInfoBytes.Length);

var magic = BitConverter.ToUInt32(magicBytes, 0);
var cpuInfo = BitConverter.ToUInt32(cpuInfoBytes, 0);
Expand All @@ -435,6 +434,27 @@ public bool TryGetDotnetPathByArchitecture(
return null;
}

#if NET
private static void ReadExactly(Stream stream, byte[] buffer, int offset, int count)
{
stream.ReadExactly(buffer, offset, count);
}
#else
private static void ReadExactly(Stream stream, byte[] buffer, int offset, int count)
{
while (count > 0)
{
int read = stream.Read(buffer, offset, count);
if (read <= 0)
{
throw new EndOfStreamException();
}
offset += read;
count -= read;
}
}
#endif

internal enum MacOsCpuType : uint
{
Arm64Magic = 0x0100000c,
Expand Down