fix (macos): app not closing on cmd+q (only windows close)

[chrispalmo]

Steps to Reproduce:

1. Open VS Code on macOS.
   Press Cmd + Q to quit the app.
2. Observe:
   • All windows close.
   • The app remains in the dock and Cmd + Tab app switcher.
   • Pressing Cmd + Q again results in a screen flash and error sound (if system if configured to alert on os error)
   • Only way to fully quit is via the "Code" menu → "Quit Visual Studio Code".

Does this issue occur when all extensions are disabled?:

Yes

System info

Version: 1.100.1
Commit: 91fa95b
Date: 2025-05-09T15:43:50.040Z (1 wk ago)
Electron: 34.5.1
ElectronBuildId: 11369351
Chromium: 132.0.6834.210
Node.js: 20.19.0
V8: 13.2.152.41-electron.0
OS: Darwin arm64 24.4.0

Previously

This issue was posted here #249179 and closed then crash report data was not provided. This isn't a crash, however. Just a UX bug.

[chrispalmo]

@microsoft-github-policy-service agree

[chrispalmo]

Note: this bug only exists in the production version of VSCode. It does not exist in Code - OSS as tested upon running the following on main:

cp ~/dev/vscode main $ rm -rf node_modules out .build
npm ci
npm run compile
bash scripts/code.sh

[bpasero]

@chrispalmo I cannot reproduce the original issue, nor did other users report them, so something must be off with your setup specifically.

And this method should take care of setting the keybinding based on user settings:

vscode/src/vs/platform/menubar/electron-main/menubar.ts

Line 854 in 9ae5582

private likeAction(commandId: string, options: MenuItemConstructorOptions, setAccelerator = !options.accelerator): MenuItemConstructorOptions {