-
Notifications
You must be signed in to change notification settings - Fork 34.7k
Add configurable prompt file suggestions with when-clause support #263369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we use a different name than promptFilesSuggest
. We use the term suggestions in the context of code completions.
Maybe 'recommendations'? Or 'favorites'?
-
The setting allows to use context keys in user settings. That might be a first. Context keys are known to extension authors but typically not to regular users. We have a documentation if it, but it's in the extension section. There's no while editing in the settings editor and users might struggle to debug. Do we need the full power?
-
Is there listening for prompt description changes or context changes?
I added a link to the when clause in the settings. Non-extension devs users are also exposed to them for customizing keyboard shortcuts, which is a primary use case. Given that this is meant to be a out of the box customization driven by power users for their other maintainers; it should be ok to not live-update descriptions, but biasing towards low performance impact and keep iterating on how this is being adopted. |
Havinc icons for prompts and modes would be neat, I agree. Locally I dropped in a play button and it makes it even more "clickable". |
e951f6c
to
a6d07f3
Compare
a51098d
to
035e0ea
Compare
Summary
This PR introduces a new
promptFilesRecommendations
configuration setting that allows users to configure which prompt files should be suggested in the chat welcome view based on contextual when-clause expressions or simple boolean values.cc @eli-w-king
Key Features
true
/false
) and when-clause expressionsConfiguration Example
Implementation Details
Configuration Schema
oneOf
constraints supporting mixed boolean/string typesUI Integration
ChatWidget
with intelligent prompt suggestion logicWelcome View Improvements
Testing
Related Issues
Enhances the reusable prompts feature by making suggestions context-aware and user-configurable.
Breaking Changes
None - this is an additive feature with sensible defaults.