Publish Dialog - Advanced deployment options #20346

ssreerama · 2025-10-22T20:23:25Z

Pull Request Template – vscode-mssql

Description

This PR introduces support for updating deployment options within the Publish Project workflow:

Advanced Options Drawer
- An Advanced Options button is added at the bottom of the dialog.
- Clicking it opens a mini drawer with expandable/collapsible option groups, along with Reset and OK buttons.
Available Option Groups
- Currently includes General, Ignore, and Exclude Object Types.
Profile Integration
- Users can save and reload deployment options using the Publish Profile select and save buttons.
Action Buttons
- Reset restores options to their initial state.
- OK or ‘X’ applies or clears selections and closes the drawer.
Testing:
- Added tests to validate option selection and loading from profiles.

Code Changes Checklist

New or updated unit tests added
All existing tests pass (npm run test)
Code follows contributing guidelines
Telemetry/logging updated if relevant
No regressions or UX breakage

Reviewers: Please read our reviewer guidelines

…odePublishDialog_4AdvancedOption

…ons and few tests

Copilot

Pull Request Overview

This PR adds an "Advanced Deployment Options" drawer to the Publish Project dialog, allowing users to configure deployment options through a UI instead of manually editing XML profiles. The implementation includes support for loading, modifying, and saving deployment options with the publish profile.

Key changes:

New advanced deployment options drawer component with search and categorized options (General, Ignore, Exclude Object Types)
State management for deployment options including a new updateDeploymentOptions reducer
Integration with DacFx service to load and save deployment options from/to publish profiles

Reviewed Changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
test/unit/publishProjectWebViewController.test.ts	Added tests for updateDeploymentOptions reducer, profile loading with deployment options, and option grouping
src/sharedInterfaces/publishDialog.ts	Added defaultDeploymentOptions to state and updateDeploymentOptions to reducers/provider interface
src/reactviews/pages/PublishProject/publishProjectStateProvider.tsx	Implemented updateDeploymentOptions action in state provider
src/reactviews/pages/PublishProject/publishProject.tsx	Added Advanced button and drawer integration to the main dialog
src/reactviews/pages/PublishProject/components/advancedDeploymentOptionsDrawer.tsx	New component implementing the advanced options drawer with search, categorization, and local change tracking
src/reactviews/common/locConstants.ts	Added localized strings for advanced options UI
src/publishProject/publishProjectWebViewController.ts	Implemented updateDeploymentOptions reducer and improved profile loading with deployment options support
src/constants/locConstants.ts	Added backend localized string constants
localization/xliff/vscode-mssql.xlf	Added translation units for new strings
localization/l10n/bundle.l10n.json	Added English translations for new strings

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-10-29T03:52:47Z

src/reactviews/pages/PublishProject/components/advancedDeploymentOptionsDrawer.tsx

+                    if (value && !excludedTypes.includes(optionName)) {
+                        excludedTypes.push(optionName);
+                    } else if (!value && excludedTypes.includes(optionName)) {
+                        excludedTypes.splice(excludedTypes.indexOf(optionName), 1);


The code compares optionName (lowercase key from objectTypesDictionary) with items in excludedTypes array (which contains display names like 'Users', 'Logins') using a case-sensitive comparison. This is inconsistent with the loading logic at line 146 which uses case-insensitive comparison. The comparison should be case-insensitive and compare against the display name from objectTypesDictionary, not the key. Update to: const displayName = updatedOptions.objectTypesDictionary[optionName]; if (value && !excludedTypes.some(t => t.toLowerCase() === displayName.toLowerCase())) { excludedTypes.push(displayName); } else if (!value) { const index = excludedTypes.findIndex(t => t.toLowerCase() === displayName.toLowerCase()); if (index !== -1) excludedTypes.splice(index, 1); }

Suggested change

if (value && !excludedTypes.includes(optionName)) {

excludedTypes.push(optionName);

} else if (!value && excludedTypes.includes(optionName)) {

excludedTypes.splice(excludedTypes.indexOf(optionName), 1);

const displayName = updatedOptions.objectTypesDictionary[optionName];

if (value && !excludedTypes.some(t => t.toLowerCase() === displayName.toLowerCase())) {

excludedTypes.push(displayName);

} else if (!value) {

const index = excludedTypes.findIndex(t => t.toLowerCase() === displayName.toLowerCase());

if (index !== -1) excludedTypes.splice(index, 1);

Copilot · 2025-10-29T03:52:48Z

src/reactviews/pages/PublishProject/components/advancedDeploymentOptionsDrawer.tsx

+        }
+
+        return groups;
+    }, [state.deploymentOptions, localChanges, loc, getCurrentValue]);


The useMemo dependency array includes getCurrentValue which is a function defined within the component (line 79). This function is recreated on every render, causing the memo to recompute unnecessarily. Either move getCurrentValue inside the useMemo, or memoize it with useCallback.

Copilot · 2025-10-29T03:52:48Z

src/reactviews/pages/PublishProject/components/advancedDeploymentOptionsDrawer.tsx

+        return groups;
+    }, [state.deploymentOptions, localChanges, loc, getCurrentValue]);
+
+    // Options change handler, inserts and removed the changed option in localChanges


Corrected spelling of 'removed' to 'removes' for grammatical correctness in the comment.

Suggested change

// Options change handler, inserts and removed the changed option in localChanges

// Options change handler, inserts and removes the changed option in localChanges

…odePublishDialog_4AdvancedOption

ssreerama added 8 commits October 16, 2025 22:55

advanced drawer initial implementation

6267375

Loc

722110e

Merge branch 'sai/vscodePublishDialog_3ServerConnection' into sai/vsc…

2a9dc0d

…odePublishDialog_4AdvancedOption

Merge branch 'sai/vscodePublishDialog_3ServerConnection' into sai/vsc…

e14e9be

…odePublishDialog_4AdvancedOption

Merge branch 'sai/vscodePublishDialog_3ServerConnection' into sai/vsc…

059c0bc

…odePublishDialog_4AdvancedOption

Merge branch 'sai/vscodePublishDialog_3ServerConnection' into sai/vsc…

c5fc619

…odePublishDialog_4AdvancedOption

ignore option group added

2ae2d40

LOC

d97d352

ssreerama changed the base branch from main to sai/vscodePublishDialog_3ServerConnection October 22, 2025 20:23

ssreerama added 6 commits October 27, 2025 16:11

Merge branch 'sai/vscodePublishDialog_3ServerConnection' into sai/vsc…

c75432d

…odePublishDialog_4AdvancedOption

Merge branch 'sai/vscodePublishDialog_3ServerConnection' into sai/vsc…

f210b46

…odePublishDialog_4AdvancedOption

all are done except update profile and save profile changes with opti…

01c1dbc

…ons and few tests

removed unnecessary advancedgroup options state

4adadcb

test updates

8c0288e

fixing the reset button and refactoring the comments

c7c0490

ssreerama changed the title ~~Sai/vscode publish dialog 4 advanced option~~ Publish Dialog - Advanced deployment options Oct 28, 2025

final changes

f31b41e

ssreerama requested a review from Copilot October 29, 2025 03:50

Copilot AI reviewed Oct 29, 2025

View reviewed changes

Merge branch 'sai/vscodePublishDialog_3ServerConnection' into sai/vsc…

23d85b1

…odePublishDialog_4AdvancedOption

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Publish Dialog - Advanced deployment options #20346

Publish Dialog - Advanced deployment options #20346

Uh oh!

ssreerama commented Oct 22, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Oct 29, 2025

Uh oh!

Copilot AI Oct 29, 2025

Uh oh!

Copilot AI Oct 29, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

-                    if (value && !excludedTypes.includes(optionName)) {
-                        excludedTypes.push(optionName);
-                    } else if (!value && excludedTypes.includes(optionName)) {
-                        excludedTypes.splice(excludedTypes.indexOf(optionName), 1);
+                    const displayName = updatedOptions.objectTypesDictionary[optionName];
+                    if (value && !excludedTypes.some(t => t.toLowerCase() === displayName.toLowerCase())) {
+                        excludedTypes.push(displayName);
+                    } else if (!value) {
+                        const index = excludedTypes.findIndex(t => t.toLowerCase() === displayName.toLowerCase());
+                        if (index !== -1) excludedTypes.splice(index, 1);

	// Options change handler, inserts and removed the changed option in localChanges
	// Options change handler, inserts and removes the changed option in localChanges

Uh oh!

Publish Dialog - Advanced deployment options #20346

Are you sure you want to change the base?

Publish Dialog - Advanced deployment options #20346

Uh oh!

Conversation

ssreerama commented Oct 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request Template – vscode-mssql

Description

Code Changes Checklist

Reviewers: Please read our reviewer guidelines

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Oct 29, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 29, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 29, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

ssreerama commented Oct 22, 2025 •

edited

Loading