Skip to content

Add user-review-requested to grammar #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add user-review-requested to grammar #124

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ad8f375
Add user-review-requested to grammar
dgrenner Apr 13, 2022
beb0404
Merge branch 'main' into user-review-requested
dgrenner Dec 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/extension/parser/symbols.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,6 +168,7 @@ export const QueryNodeImpliesPullRequestSchema = new Set<string>([
'review',
'reviewed-by',
'team-review-requested',
'user-review-requested',
'merged',
]);

Expand Down Expand Up @@ -209,6 +210,7 @@ export const QualifiedValueNodeSchema = new Map<string, QualifiedValueInfo>([
['involves', QualifiedValueInfo.username(RepeatInfo.Repeat, 'Issues and pull requests that in some way involve a user. The involves qualifier is a logical OR between the author, assignee, mentions, and commenter qualifiers for a single user')],
['review-requested', QualifiedValueInfo.username(undefined, 'Pull requests where a specific user is requested for review')],
['reviewed-by', QualifiedValueInfo.username(undefined, 'Pull requests reviewed by a particular user')],
['user-review-requested', QualifiedValueInfo.username(undefined, 'Pull requests where a specific user is directly requested for review')],
// simple value
['closed', QualifiedValueInfo.simple(ValueType.Date, 'Issues and pull requests based on when they were closed')],
['created', QualifiedValueInfo.simple(ValueType.Date, 'Issues and pull requests based on when they were created')],
Expand Down
2 changes: 1 addition & 1 deletion syntaxes/github-issues.tmGrammar.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
},
{
"name": "keyword.other",
"match": "\\b(type|updated|in|org|repo|user|state|assignee|author|mentions|team|stars|topics|pushed|size|commenter|involves|label|linked|milestone|project|language|comments|interactions|reactions|created|closed|archived|is|no|status|base|head|draft|reason|review-requested|review|reviewed-by|team-review-requested|merged)\\b"
"match": "\\b(type|updated|in|org|repo|user|state|assignee|author|mentions|team|stars|topics|pushed|size|commenter|involves|label|linked|milestone|project|language|comments|interactions|reactions|created|closed|archived|is|no|status|base|head|draft|reason|review-requested|review|reviewed-by|team-review-requested|user-review-requested|merged)\\b"
}
]
}