-
Notifications
You must be signed in to change notification settings - Fork 8.9k
Open
Labels
Area-UserInterfaceIssues pertaining to the user interface of the Console or TerminalIssues pertaining to the user interface of the Console or TerminalIssue-ScenarioProduct-TerminalThe new Windows Terminal.The new Windows Terminal.
Milestone
Description
[Panes megathread #1000] [Original PR: #7371] [Original Issue: #4717]
Tasks
- Add a context menu entry for "close pane"
- Add a context menu entry for "zoom pane"
- Add optional "maximize/close" control
- Like the MinMaxCloseControl, but without minimize, and with "maximize" being "zoom pane"
- Should that option be in the theme? (Add comprehensive XAML "theming" functionality #3327) I'm thinking YES
- Allow moving panes to other tabs Allow moving panes to other tabs #7075
Open Discussion
- How should pane title color work with
tabColor? Add titlebars to panes #7371 (comment)
Currently, setting the tab's background color with the color picker does not update the pane titlebar color.
I think that's fine. Currently, the order of precedence is [tab runtime color, control title color, theme color (unimplemented), default color]. So I could imagine this going two ways:
- convert the "tab runtime color" to be a "pane runtime color". Then, using the color picker on the tab would set the active pane's runtime color. This comes with the detrimental side effect that you'd have to re-color each pane in a tab manually.
- add an additional "pane runtime color", and have the tab's color be composed from [tab runtime color, pane color (which is itself [pane runtime color, control title color, theme pane title color]), theme color, default]. This would allow panes to have their color changed at runtime with a color picker, and also have the tab have a manual color override.
I'm of course just hypothesizing here in the comments - I don't think any of this is something that needs to get done in this PR. We can always loop back on the issue in a follow-up.
- Should the titlebar for a pane not appear until there are multiple panes? Kinda seems like there are three states:
paneTitlebarVisibility: [never, multiplePanes, always]
Metadata
Metadata
Assignees
Labels
Area-UserInterfaceIssues pertaining to the user interface of the Console or TerminalIssues pertaining to the user interface of the Console or TerminalIssue-ScenarioProduct-TerminalThe new Windows Terminal.The new Windows Terminal.