Skip to content

[api-extractor] Upgrade bundled TypeScript to 5.8 #5151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 10, 2025
Merged

[api-extractor] Upgrade bundled TypeScript to 5.8 #5151

merged 2 commits into from
Mar 10, 2025

Conversation

rexxars
Copy link
Contributor

@rexxars rexxars commented Mar 8, 2025

Summary

Upgrade the bundled compiler engine to TypeScript 5.8.2.

Details

Allows using new erasableSyntaxOnly option, which currently fails:

api-extractor 7.51.1  - https://api-extractor.com/

Using configuration from ./api-extractor.json

ERROR: Error parsing tsconfig.json content: Unknown compiler option 'erasableSyntaxOnly'.

Seems to work fine after the upgrade.

How it was tested

Ran the build tests. Also manually overwrote the typescript version used by API extractor in a project, and seems to work just fine.

Impacted documentation

None, as far as I know.

@github-project-automation github-project-automation bot moved this to Needs triage in Bug Triage Mar 8, 2025
@rexxars
Copy link
Contributor Author

rexxars commented Mar 8, 2025

@microsoft-github-policy-service agree

@iclanton iclanton moved this from Needs triage to In Progress in Bug Triage Mar 10, 2025
@iclanton
Copy link
Member

Tested this in a large internal repo and it ran fine.

octogonz
octogonz approved these changes Mar 10, 2025
View reviewed changes
Copy link
Collaborator

@octogonz octogonz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rexxars Thanks for making this PR! 🎉

@iclanton iclanton merged commit 4aa0331 into microsoft:main Mar 10, 2025
5 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Closed in Bug Triage Mar 10, 2025
@rexxars rexxars deleted the feat/ts-85 branch March 11, 2025 16:58
@codyebberson codyebberson mentioned this pull request Mar 14, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@octogonz octogonz octogonz approved these changes

@iclanton iclanton Awaiting requested review from iclanton iclanton is a code owner

@apostolisms apostolisms Awaiting requested review from apostolisms apostolisms is a code owner

@D4N14L D4N14L Awaiting requested review from D4N14L D4N14L is a code owner

@dmichon-msft dmichon-msft Awaiting requested review from dmichon-msft dmichon-msft is a code owner

@patmill patmill Awaiting requested review from patmill patmill is a code owner

Assignees
No one assigned
Labels
None yet
Projects
Bug Triage
Status: Closed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rexxars @iclanton @octogonz