Skip to content

Conversation

@lukashass
Copy link
Contributor

Summary

Fixes #2890

How it was tested

Installed it with pnpm link <dir> and ran pnpm eslint --max-warnings 0 ..
It works with both eslint 7.29.0 and 8.0.0.

@ghost
Copy link

ghost commented Oct 13, 2021

CLA assistant check
All CLA requirements met.

@octogonz
Copy link
Collaborator

Thanks @lukashass for helping us support ESLint 8! 🙂

@iclanton iclanton enabled auto-merge October 13, 2021 06:04
@iclanton iclanton merged commit a475dd2 into microsoft:master Oct 13, 2021
@ykzts ykzts mentioned this pull request Oct 13, 2021
8 tasks
@lukashass lukashass deleted the eslint-8x branch October 13, 2021 21:18
@bhvngt
Copy link

bhvngt commented Oct 21, 2021

Hi Thanks for the PR.. Just checking if this is released. As I am getting following error with "@rushstack/eslint-config": ^2.4.3" and "eslint": "^8.0.1"

TypeError: Failed to load plugin '@rushstack/eslint-plugin' declared in '.eslintrc.cjs » @rushstack/eslint-config/profile/web-app': Class extends value undefined is not a constructor or null

Reverting eslint back to 7.32.0 removes this error.

@lukashass
Copy link
Contributor Author

@bhvngt This PR only adds eslint 8 compatibility to @rushstack/eslint-patch.

Sounds like eslint-config and/or eslint-plugin packages might need some compatibility fixes as well.

@marcoreni marcoreni mentioned this pull request Oct 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support ESLint 8.x

4 participants