Fabric: Enable react-test-renderer tests in the new cpp-app template #12376
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The upstream RN app template includes a jest test suite (run with `yarn test`) with a default test to render your app JS using the `react-test-renderer`. However, this only tests the iOS version of your app (it forces platform === 'ios') and therefore won't catch if there are issues in your `windows` platform files. Using `@rnx-kit/jest-preset`, you can run jest tests against any platform via a custom jest config. This PR adds `@rnx-kit/jest-preset` as a dev dependency to the new `cpp-app` template, as well as a `jest.config.windows.js` to use it. Furthermore it adds a script so users can run these tests for windows via `yarn test:windows`. To support this, I've extended the templateUtils added in microsoft#12374 to include functionality to run `npm i` / `yarn` to install any new dependencies added. Closes microsoft#11939
jonthysell
force-pushed
the
cpp-app-rnxkit
branch
from
d2ff55b to
f0b905b
Compare
marlenecota
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The upstream RN app template includes a jest test suite (run with
yarn test) with a default test to render your app JS using thereact-test-renderer. However, this only tests the iOS version of your app (it forces platform === 'ios') and therefore won't catch if there are issues in yourwindowsplatform files.Using
@rnx-kit/jest-preset, you can run jest tests against any platform via a custom jest config.This PR adds
@rnx-kit/jest-presetas a dependency to the newcpp-apptemplate, as well as ajest.config.windows.jsto use it. Furthermore it adds a script so users can run these tests for windows viayarn test:windows.Finally this PR adds running
yarn test:windowsto the PR checks for testing the new app CLI.Closes #11939
Type of Change
Why
To expand test coverage options for app developers.
Closes #11939
What
See above.
Screenshots
Testing
Ran the tests in the provided RN template.
Changelog
Should this change be included in the release notes: yes
The new Fabric app template supports
yarn test:windowsto run jest app rendering tests with react-test-rendererMicrosoft Reviewers: Open in CodeFlow