Skip to content

Improve README #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 25, 2021
Merged

Improve README #47

merged 2 commits into from
Oct 25, 2021

Conversation

@Marcono1234
Copy link
Contributor

@Marcono1234 Marcono1234 commented Aug 29, 2021 •
edited
Loading

  • Add missing type definition for JSONPath; matching the content of src/main.ts
  • Consistently use 4 spaces as indentation for code blocks

@ghost
Copy link

ghost commented Aug 29, 2021 •
edited by ghost
Loading

CLA assistant check
All CLA requirements met.

Marcono1234
Marcono1234 commented Aug 29, 2021
View reviewed changes
README.md
export declare function getLocation(text: string, position: number): Location;

export declare type Segment = string | number;
export declare type JSONPath = Segment[];
Copy link
Contributor Author

@Marcono1234 Marcono1234 Aug 29, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not completely sure if declare is needed here; the README does not seem to use it consistently.

@aeschli aeschli merged commit 81825b0 into microsoft:main Oct 25, 2021
@aeschli aeschli self-assigned this Oct 25, 2021
@aeschli aeschli added this to the October 2021 milestone Oct 25, 2021
@aeschli
Copy link
Contributor

aeschli commented Oct 25, 2021

Thanks a lot, @Marcono1234 !

@Marcono1234 Marcono1234 deleted the patch-1 branch October 25, 2021 19:53
@Exkaleburx Exkaleburx mentioned this pull request Jul 15, 2024
Open
@SherfeyInv SherfeyInv mentioned this pull request Jul 15, 2024
Open
@snyk-io snyk-io bot mentioned this pull request Jul 15, 2024
Open
@Exkaleburx Exkaleburx mentioned this pull request Jul 16, 2024
Open
@Robot-Inventor Robot-Inventor mentioned this pull request Jul 16, 2024
Open
@Linjieqiong001 Linjieqiong001 mentioned this pull request Jul 16, 2024
Open
@ghaschel ghaschel mentioned this pull request Jul 17, 2024
Open
@Stanislav1975 Stanislav1975 mentioned this pull request Aug 9, 2024
Open
@ashly1111111 ashly1111111 mentioned this pull request Sep 6, 2024
Open
@Exkaleburx Exkaleburx mentioned this pull request Sep 9, 2024
Open
@VivekKumar06 VivekKumar06 mentioned this pull request Sep 10, 2024
Open
@lucentlabz lucentlabz mentioned this pull request Sep 10, 2024
Merged
@XavierMP14 XavierMP14 mentioned this pull request Sep 17, 2024
Open
@Bonniemarie216 Bonniemarie216 mentioned this pull request Oct 18, 2024
Open
@Sabiiii9944 Sabiiii9944 mentioned this pull request Oct 24, 2024
Open
@HaLaGu1L HaLaGu1L mentioned this pull request Nov 1, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@aeschli aeschli

Labels

None yet

Projects

None yet

Milestone

October 2021

Development

Successfully merging this pull request may close these issues.

2 participants

@Marcono1234 @aeschli