Sync WebView2 code with WinUI 3 #7351
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
codendone
reviewed
Jul 11, 2022
| } | ||
|
|
||
| void WebView2::UpdateDefaultBackgroundColor() | ||
| void WebView2::UpdateDefaultVisualBackgroundColor() |
There was a problem hiding this comment.
Does SpriteVisual have a similar background property we would ever want to use? If not, I'm happy to take it out.
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ojhad
added
area-WebView
team-Rendering
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove "#ifdef WinUI3" that doesn't run. Align sections of code that were in different places in the different code bases. Run all WebView2 tests down-level.
Fix issue where we were revoking m_pointerPressedRevoker twice, and revoke m_pointerReleasedRevoker instead.