Changing CommandBarFlyout to not take keyboard focus when opened in transient mode #6844
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cus if it's being opened in transient mode.
ghost
added
the
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
llongley
commented
Mar 17, 2022
RBrid
requested changes
Mar 17, 2022
dev/CommandBarFlyout/InteractionTests/TextCommandBarFlyoutTests.cs
Outdated
Show resolved
Hide resolved
ojhad
added
team-Controls
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
RBrid
approved these changes
Mar 18, 2022
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CommandBarFlyout was changed to unconditionally give keyboard focus to the first focusable command when it opens. This breaks the assumption when opening in transient mode that the flyout won't take keyboard focus in that mode. We should only give keyboard focus when opening in standard mode.
Also added a test to make sure that this doesn't regress in the future.