Skip to content

Conversation

bkudiess
Copy link
Contributor

Screen readers were reading it the status and name of progress ring as one word, since we were concatenating them without a space.

For example, if you progress ring is called Troubleshooter it was reading "BusyTroubleshooter".

This PR adds the missing space for correct narrator reading.

@ghost ghost added the needs-triage Issue needs to be triaged by the area owners label Mar 14, 2022
Copy link
Member

@kmahone kmahone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@ojhad ojhad added accessibility Narrator, keyboarding, UIA, etc area-Progress ProgressBar, ProgressRing team-Controls Issue for the Controls team and removed needs-triage Issue needs to be triaged by the area owners labels Mar 14, 2022
@ranjeshj
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@kmahone kmahone closed this Mar 18, 2022
@kmahone kmahone reopened this Mar 18, 2022
@ghost ghost added the needs-triage Issue needs to be triaged by the area owners label Mar 18, 2022
@bkudiess
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ojhad ojhad removed the needs-triage Issue needs to be triaged by the area owners label Mar 18, 2022
@bkudiess
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@bkudiess bkudiess merged commit 1697d94 into main Mar 21, 2022
@bkudiess bkudiess deleted the user/bakudiess/progressring-narrator-fix branch March 21, 2022 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

accessibility Narrator, keyboarding, UIA, etc area-Progress ProgressBar, ProgressRing team-Controls Issue for the Controls team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants