Fix usage of WinUI 2.7+ in xaml islands C++ apps #5990
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
asklar
changed the title
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jevansaks
approved these changes
Sep 28, 2021
ranjeshj
added
area-WebView
team-Controls
|
🎉 Handy links: |
|
🎉 Handy links: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes consumption of webview2 nuget package so winui can be used in xaml islands apps
Fixes #5793
Description
Set the new flag we added for WV2 to reference/copy the WV2 winmd file.
Motivation and Context
This is necessary in xaml islands apps since WV2 otherwise relies on the app type being UAP, and also because WinUI's winmd now references the WV2 winmd, so this is necessary even if the xaml islands app does not use webview2.
How Has This Been Tested?
Locally validated adding the property to microsoft.ui.xaml.targets does the trick