You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to make two updates to get acrylic to work properly in XAML islands:
Flyouts should use in-app acrylic rather than HostBackdrop, since they're being drawn on top of other content in the app.
We should use the system XAML version of AcrylicBrush - that properly accounts for XAML islands, whereas the WinUI 2 version does not.
With these two changes, acrylic works properly in both a UWP app and a XAML islands app. I modified WpfApp to add some flyouts and a rainbow background to showcase this scenario and get a XAML islands app on which this can be tested, and also modified some pages in MUXControlsTestApp to add a rainbow background there as well to make it easier to tell if acrylic is working properly.
I'm assuming these changes are only related to WinUI 2.X versions, and WinUI 3.X doesn't use any System Acrylic? (Which for 3.0 means in app acrylic only until HostBackdrop is working)
Flyouts should use in-app acrylic rather than HostBackdrop, since they're being drawn on top of other content in the app.
This is not correct. Flyouts in system XAML islands can show up on top of non-app content. This change would make so that it wouldn't be transparent to non-app content.
Flyouts should use in-app acrylic rather than HostBackdrop, since they're being drawn on top of other content in the app.
This is not correct. Flyouts in system XAML islands can show up on top of non-app content. This change would make so that it wouldn't be transparent to non-app content.
I thought WinUI 2.0 XAML Islands were bound to the app window?
I'm assuming these changes are only related to WinUI 2.X versions, and WinUI 3.X doesn't use any System Acrylic? (Which for 3.0 means in app acrylic only until HostBackdrop is working)
Yes, that's correct, this is only for WinUI 2.
This is not correct. Flyouts in system XAML islands can show up on top of non-app content. This change would make so that it wouldn't be transparent to non-app content.
From my testing, BackgroundSource="Backdrop" still works as expected when the flyout is over non-app content.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ghost
added
the
llongley
changed the title
StephenLPeters
added
area-Materials
We need to make two updates to get acrylic to work properly in XAML islands:
With these two changes, acrylic works properly in both a UWP app and a XAML islands app. I modified WpfApp to add some flyouts and a rainbow background to showcase this scenario and get a XAML islands app on which this can be tested, and also modified some pages in MUXControlsTestApp to add a rainbow background there as well to make it easier to tell if acrylic is working properly.