Add version json #4739
Merged
Add version json #4739
+1
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shankarseal
requested review from
Alan-Jowett,
LakshK98,
dthaler,
matthewige,
mikeagun,
mtfriesen,
poornagmsft and
saxena-anurag
as code owners
saxena-anurag
approved these changes
Oct 17, 2025
mikeagun
approved these changes
Oct 17, 2025
dthaler
reviewed
Oct 17, 2025
There was a problem hiding this comment.
I think there is a problem with this PR, but I didn't get a chance to comment before it was merged.
- The PR description says there is no impact on documentation.
docs\ReleaseProcess.mdhas a section entitled "Updating the Product Version" that says you just need to run.\scripts\update-product-version.ps1 X Y Z. - update-product-version.ps1 was not updated and so is not aware of version.json.
Taken together, this means the documentation is wrong and this is a regression.
This was referenced Oct 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe the purpose of and changes within this Pull Request.
Adds a version json file that is needed by the official build pipeline that is internal to Microsoft.
Testing
Do any existing tests cover this change? Are new tests needed?
No new tests.
Documentation
Is there any documentation impact for this change?
No documentation changes needed.
Installation
Is there any installer impact for this change?
No installation changes needed.