PS: Improve sinks in powershell/command-injection
#141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR started off with me wanting to extending the set of sinks in the new
powershell/command-injectionquery, but ended up with me redesigning some of the internals of API graphs for PowerShell.Now, just like in other languages, an exclamation mark on the type column marks that a member/method is static.
After those changes, I'm adding a bunch of type models / sink models to the
powershell/command-injectionquery.I'm not quite happy with how the GAC modules are handled (global assembly cache), but I can't think of a good way to handle that other than also extracting the GAC list during extraction. But I didn't want to go there yet.