Powershell: Fix dataflow/SSA consistency errors. #110
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdrodes
pushed a commit
that referenced
this pull request
Jan 9, 2025
Expect external workflows and actions in .github/workflow/external and .github/actions/external
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the dataflow consistency queries for Powershell, and also fixes the worst offenders. In particular, every dataflow node must have an enclosing callable, and I had forgotten to implement this predicate 😅
In addition, Poweshell, unfortunately, needs dataflow nodes for certain statements (because of the structure of the AST), and I had forgotten to include these in SSA.
Both of these problems are fixed in this PR. There are no changes to results because we're still missing loads of control flow.