Fix smoke test substitution #51494
Merged
Fix smoke test substitution #51494
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
Author: Team
For Uncommitted Bug
weswigham
approved these changes
Nov 11, 2022
Member
weswigham
left a comment
weswigham
left a comment
There was a problem hiding this comment.
Does the ending sequence not need to change?
Member
Author
|
Nope, this is some silly bashism where if you quote the string (single or double), then it won't interpolate the string, but the ending sequence is still the same. Annoying. https://stackoverflow.com/questions/22697688/how-to-cat-eof-a-file-containing-code I tested it locally this time... |
Member
Author
|
Alright, there's now logging so one can see what it's doing, kinda like playwright. Which, begs the question as to whether or not I should be just making a smoke test script which tests all of that together instead, but that's another day. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just merged the smoke test from #51464, but while it passed, I reread the logs on main and saw that it didn't actually work as expected; the heredoc wasn't in the right format and so was interpolating some of the code when I just wanted it raw.
Maybe I should just make it a script in the repo :\