JSDoc:Object<string, T> creates index signature #17254
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And `Object<number, T>` creates a numeric index signature. Other uses still create `any` as before.
DanielRosenwasser
requested changes
Jul 17, 2017
src/compiler/checker.ts
Outdated
| return node.flags & NodeFlags.JSDoc && node.kind === SyntaxKind.TypeReference; | ||
| } | ||
|
|
||
| function getPrimitiveTypeFromJSDocTypeReference(node: TypeReferenceNode): Type { |
Member
There was a problem hiding this comment.
This isn't really an apropos name anymore. Perhaps call this getIntendedTypeFromJsDocTypeReference.
Member
Author
There was a problem hiding this comment.
Yeah, I like your suggested name too.
weswigham
approved these changes
Jul 18, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And
Object<number, T>creates a numeric index signature. Other uses still map toanyas before.Fixes #15105