Skip to content

Conversation

@irvinesunday
Copy link
Contributor

Fixes #197

This PR:

  • Proposes a new convert setting: UseStringArrayForQueryOptionsSchema for toggling between generating schemas
    of query options of type string array or enums.
  • Uses the above convert setting when generating schemas of query options: $select, $expand and $orderby
  • Updates tests to validate the above.
  • Updates release notes

@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 1, 2024

Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick turnaround on this one!
Once this is released, can you please release hidi as well?
(and update GE convert settings in the metadata repo to set this new switch to false)

@irvinesunday
Copy link
Contributor Author

Thanks for the quick turnaround on this one! Once this is released, can you please release hidi as well? (and update GE convert settings in the metadata repo to set this new switch to false)

Will sure do 👍🏽

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

$expand is reported as enum while it is actually string

3 participants