Skip to content

Conversation

@irvinesunday
Copy link
Contributor

Fixes #486

This PR:

  1. Fixes navigation property paths generated via composable functions by:
  • Appending any function parameters to the list of parameters.
  • Including the function name in the operation id name. This will help in avoiding duplicates in similar navigation property paths that don't have the composable function. This has been achieved by refactoring the function parameter generation into the central OpenApiParameterGenerator class instead of in the OperationOperationHandler class.
  1. Add a test to validate the above fixes/refactorings.
  2. Update the release note

…enerated

Example of operations and parameters of paths that weren't being generated were of navigation properties generated via composable functions
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 2, 2024

Quality Gate Failed Quality Gate failed

Failed conditions

76.2% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@irvinesunday irvinesunday merged commit 5513183 into master Feb 2, 2024
@irvinesunday irvinesunday deleted the is/composite-fxns-params-opids branch February 2, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Parameter not defined at path level for composable bound functions.

3 participants