Skip to content

Adds delete operation for non-contained navigation properties only if explicitly allowed via annotation #484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Feb 1, 2024
Merged

Adds delete operation for non-contained navigation properties only if explicitly allowed via annotation #484

merged 8 commits into from
Feb 1, 2024

Conversation

@irvinesunday
Copy link
Contributor

Fixes #483

This PR:

  • Ensures delete operations for non-contained nav. props is generated only if DeleteRestrictions exists for this nav. prop and the Deletable property is set to true.
  • Updates test to validate the above.
  • Updates release note.
  • Minor documentation text fixes to the convert settings.

@irvinesunday irvinesunday self-assigned this Jan 31, 2024
baywet
baywet requested changes Jan 31, 2024
View reviewed changes
andrueastman
andrueastman previously approved these changes Feb 1, 2024
View reviewed changes
baywet
baywet requested changes Feb 1, 2024
View reviewed changes
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 1, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

1 New issue
0 Security Hotspots
96.4% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

baywet
baywet approved these changes Feb 1, 2024
View reviewed changes
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the changes!

@irvinesunday irvinesunday merged commit b5e8145 into master Feb 1, 2024
@irvinesunday irvinesunday deleted the is/non-containment-deletability branch February 1, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@baywet baywet baywet approved these changes

@xuzhg xuzhg Awaiting requested review from xuzhg

@darrelmiller darrelmiller Awaiting requested review from darrelmiller

@peombwa peombwa Awaiting requested review from peombwa

@zengin zengin Awaiting requested review from zengin

@millicentachieng millicentachieng Awaiting requested review from millicentachieng

+1 more reviewer

@andrueastman andrueastman andrueastman left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@irvinesunday irvinesunday

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add delete operation for non-contained nav. props only if explicitly allowed via annotation

4 participants

@irvinesunday @andrueastman @baywet