Skip to content

Conversation

@irvinesunday
Copy link
Contributor

Fixes #467

This PR:

  • Ensures that schemas of properties of collection of complex types are consistent with those of entity types, such that:
identities:
  type: array
  items:
    anyOf:
      - $ref: '#/components/schemas/microsoft.graph.objectIdentity'
      - type: object
         nullable: true

should be...

identities:
  type: array
  items:
    $ref: '#/components/schemas/microsoft.graph.objectIdentity'

[NB] Collection of structured types are not nullable.

  • Updates tests
  • Updates release notes

@sonarqubecloud
Copy link

Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marvelous!

@irvinesunday irvinesunday merged commit d5e10af into master Jan 25, 2024
@irvinesunday irvinesunday deleted the is/collections-nullability branch January 25, 2024 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

nullability information for properties that are collections of complex or entity types is inconsistent

3 participants