[Fix] Adds a delete operation and a required @id query parameter to collection-valued nav. property paths with $ref
#477
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We no longer use containment to determine whether or not to create $ref segments for nav. props.; we use referenceable annotations. Hence the Debug.Assert needs omission. The query parameter @id needs to be required in the delete operation of col-valued nav. props. with $ref segments because you need to index into the collection before deleting
irvinesunday
requested review from
andrueastman,
baywet,
darrelmiller,
millicentachieng,
peombwa,
xuzhg and
zengin
as code owners
irvinesunday
changed the title
delete operation to collection-valued nav. property paths with $ref and with a required @id query paramdelete operation and a required @id query parameter to collection-valued nav. property paths with $ref
|
andrueastman
approved these changes
Jan 22, 2024
baywet
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #453
This PR:
deleteoperation to collection-valued nav. paths with$ref. A required query param of@idis also included in the list of parameters.