Skip to content

Conversation

@irvinesunday
Copy link
Contributor

Fixes #365

This PR:

  • Aliases operation or type cast segments when a namespace alias is available in the model.
  • If the above is not possible, we strip off the namespace prefixes from operation segments when the value of the NamespacePrefixToStripForInMethodPaths matches the namespace of the operation. If these values doesn't match, we don't strip off the namespace.
  • Updates unit tests.
  • Updates release notes.

baywet
baywet previously approved these changes Apr 10, 2023
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick turnaround on this one. I'd like another review from @andrueastman before we merge it.

baywet
baywet previously approved these changes Apr 10, 2023
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick turnaround on this one. I'd like another review from @andrueastman before we merge it.

baywet
baywet previously approved these changes Apr 10, 2023
andrueastman
andrueastman previously approved these changes Apr 13, 2023
@irvinesunday irvinesunday requested a review from baywet April 13, 2023 11:38
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

92.8% 92.8% Coverage
0.0% 0.0% Duplication

Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for driving this through

@irvinesunday irvinesunday merged commit f9e45d0 into master Apr 13, 2023
@irvinesunday irvinesunday deleted the fix/is/ops-namespace-stripping branch April 13, 2023 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Namespace stripping for functions/actions.

4 participants