[Fix] DELETE methods should always return response status code 204

[irvinesunday]

Fixes #366

This PR:

• Ensures that delete methods always return status code 204. This is regardless of whether UseSuccessStatusCodeRange is true.
• Adds test to validate the above.

[sonarqubecloud]

SonarCloud Quality Gate failed.   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

100.0% Coverage
45.5% Duplication

[github-advanced-security]

You have successfully added a new SonarCloud configuration ``. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

[baywet]

I'm a bit late to the party here. But if we could avoid allocs for that kind of thing, it'd be better. Could we not check the operation method/verb in the AddErrorResponses method instead? @irvinesunday

[irvinesunday]

I thought about it, but I was avoiding growing this function by adding an extra optional parameter (which will only be utilized by delete methods) and conditional checks here. I also wanted to be explicit that we are not using success status code range for delete methods.

[baywet]

thanks for the additional context here. Would it have been another parameter since it's an extension method on operation and thus it has access to the operation properties?

[irvinesunday]

But you can't infer the OperationType from the operation object properties. This is in the Operations property dictionary key of an OpenApiPathItem object: https://github.com/microsoft/OpenAPI.NET/blob/df1b405e537d0f3c2a829b6a80fef82959d0eab5/src/Microsoft.OpenApi/Models/OpenApiPathItem.cs#L29
Operation properties: https://github.com/microsoft/OpenAPI.NET/blob/df1b405e537d0f3c2a829b6a80fef82959d0eab5/src/Microsoft.OpenApi/Models/OpenApiOperation.cs#L119-L131

[baywet]

ah right, I forgot about the dictionary pattern, which is a bit painful to carry the context around. Fine, leave it as is for now, thanks for taking the time to discuss this.

[irvinesunday]

No worries.